You should divide it into small separated pull requests
Good impression helps a lot
這是⼀一個 "最熟悉的陌⽣生⼈人" 的概念
Detail matters 細節
Busy people are usually too busy to listen, think or understand ...
A good brief helps reviewer quickly understand the changes
BugFix PR should contain a failing test case and the way to reproduce the problem.
To proof it's author's fault
Or.. to prevent things like this...
At least it prevents from the time- ‐ consuming communication
PR For Feature • Objective • Summary • Effect (Or side effect) • Tests
Maintainers usually worry about breaking backward compatibility, build system, dependencies. . etc
It's also important to get continuous testing pass
When adding new features, good tests also help author to verify the changes
Write down the side effects to show your careful thoughts to the author
Just Ask 問就對了
Asia people usually are too shy to ask
有時專案作者很少會寫下⾃自 ⼰己的⼼心中顧慮的部分 Sometimes people just don't write down their concern on GitHub
When you don't get reply, you should ask
"If you have any concern, please let me know" also ping them back to reply
Timezone 時區有差 matters
Human beings usually check their e- ‐mail in the morning
For company sponsored projects, people usually check newly opened issues in daylight.
For just- ‐for- ‐fun projects, people usually check the issues in night.
Some non- ‐Asia people usually don't check e- ‐mail or work on weekend
Don't expect their e- ‐mail on the weekend
They have life!
And for Asia people, you can just poke around, they will reply you all day
San Francisco people get up at 01:00 AM Taipei Time (GMT+8)
And they get off work at 10:00 AM Taipei Time (GMT+8)
People from London get up at 15:00 PM Taipei Time
They are having their lunch while you're having dinner!
要得到快速回覆 To get response instantly
你應該在正確的時間點發信 You should send/reply at the correct time
And you shall mostly get the response quicker then you thought.
And once you get the ping, you have to pong back quickly
First in, First out
Last In, Never Out
Because they've got off work
Timezone overlapping The lines on this map show 12 cities’ typical working day, beginning with 9 AM on the right and ending at 5 PM on the left, and each workday’s overlap with time zones around the world. Each clock shows that city’s workday overlap with other cities’ and the best time to schedule a call. https://hbr.org/2010/10/vision-statement-why-mumbai- at-1-pm-is-the-center-of-the-business-world